Skip to content

Commit 490bda6

Browse files
committed
set int prec for conv, remove old vips7 code
8.6 will default to float for conv, so we need to force int remove old vips7 progs
1 parent 23ad918 commit 490bda6

File tree

10 files changed

+11
-53
lines changed

10 files changed

+11
-53
lines changed

benchmark.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,6 @@ benchmark vips-c "./vips-c $tmp/x.tif $tmp/x2.tif"
9595
echo -n strip-
9696
benchmark vips-c "./vips-c $tmp/x_strip.tif $tmp/x2.tif"
9797

98-
g++ vips.cc `pkg-config vipsCC --cflags --libs` -o vips-cc
99-
benchmark vips-cc "./vips-cc $tmp/x.tif $tmp/x2.tif"
100-
10198
gcc -Wall vips.c `pkg-config vips --cflags --libs` -o vips-c
10299
echo -n ppm-
103100
benchmark vips-c "./vips-c $tmp/x.ppm $tmp/x2.ppm"
@@ -106,8 +103,6 @@ benchmark vips.lua "./vips.lua $tmp/x.tif $tmp/x2.tif"
106103

107104
benchmark vips.php "./vips.php $tmp/x.tif $tmp/x2.tif"
108105

109-
benchmark vips.py "./vips.py $tmp/x.tif $tmp/x2.tif"
110-
111106
benchmark vips8-gegl.py "./vips8-gegl.py $tmp/x.tif $tmp/x2.tif"
112107

113108
g++ vips8.cc `pkg-config vips-cpp --cflags --libs` -o vips8-cc

ruby-vips.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
im = Vips::Image.new_from_file ARGV[0]
66

77
im = im.crop 100, 100, im.width - 200, im.height - 200
8-
im = im.similarity :scale => 0.9
8+
im = im.similarity scale: 0.9
99
mask = Vips::Image.new_from_array [
1010
[-1, -1, -1],
1111
[-1, 16, -1],
1212
[-1, -1, -1]], 8
13-
im = im.conv(mask)
13+
im = im.conv mask, precision: "integer"
1414

1515
im.write_to_file ARGV[1]
1616

vips.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ main( int argc, char **argv )
3939
"scale", 0.9,
4040
"interpolate", interp,
4141
NULL ) ||
42-
vips_conv( t[3], &t[4], t[1], NULL ) ||
42+
vips_conv( t[3], &t[4], t[1],
43+
"precision", VIPS_PRECISION_INTEGER,
44+
NULL ) ||
4345
vips_image_write_to_file( t[4], argv[2], NULL ) )
4446
vips_error_exit( NULL );
4547

vips.cc

Lines changed: 0 additions & 22 deletions
This file was deleted.

vips.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
[[-1, -1, -1],
1616
[-1, 16, -1],
1717
[-1, -1, -1]], 8);
18-
$im = $im->conv($mask);
18+
$im = $im->conv($mask, ["precision" => "integer"]);
1919

2020
$im->writeToFile($argv[2]);
2121

vips.py

Lines changed: 0 additions & 18 deletions
This file was deleted.

vips.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ cat > mask.con <<EOF
1717
-1 16 -1
1818
-1 -1 -1
1919
EOF
20-
vips conv t2.v $2 mask.con
20+
vips conv t2.v $2 mask.con --precision integer
2121

2222
rm t1.v t2.v

vips8-gegl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
mask = Vips.Image.new_from_array([[-1, -1, -1],
1818
[-1, 16, -1],
1919
[-1, -1, -1]], scale = 8)
20-
im = im.conv(mask)
20+
im = im.conv(mask, precision = "integer")
2121

2222
im = im.colourspace("srgb")
2323
im = im.extract_band(0, n = 3)

vips8.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ main( int argc, char **argv )
4141
similarity( VImage::option()->
4242
set( "scale", 0.9 )->
4343
set( "interpolate", inter ) ).
44-
conv( mask ).
44+
conv( mask, VImage::option()->
45+
set( "precision", VIPS_PRECISION_INTEGER )).
4546
write_to_file( argv[2] );
4647

4748
return( 0 );

vips8.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
mask = Vips.Image.new_from_array([[-1, -1, -1],
1515
[-1, 16, -1],
1616
[-1, -1, -1]], scale = 8)
17-
im = im.conv(mask)
17+
im = im.conv(mask, precision = "integer")
1818

1919
im.write_to_file(sys.argv[2])

0 commit comments

Comments
 (0)