Explicitly add hostname for SNI to start_SSL (Fix libwww-perl#57)#17
Merged
genio merged 1 commit intolibwww-perl:masterfrom Feb 20, 2017
noxxi:sni-fix
Merged
Explicitly add hostname for SNI to start_SSL (Fix libwww-perl#57)#17genio merged 1 commit intolibwww-perl:masterfrom noxxi:sni-fix
genio merged 1 commit intolibwww-perl:masterfrom
noxxi:sni-fix
Conversation
Sometimes IO::Socket::SSL fails to detect the proper hostname for SNI from PeerHost inside start_SSL. This way the name is explicitly given.
noxxi
changed the title
|
my $ua = LWP::UserAgent->new(ssl_opts => { SSL_hostname => '', SSL_verifycn_name => '' , SSL_verify_mode => 0x00, verify_hostname => 0 }); |
This was referenced Feb 19, 2017
Member
|
Looks good to me. |
|
It would be great to get this merged. We have been running a fork based on #24 since we ran into this a year and a half ago. |
genio
added a commit
that referenced
this pull request
Feb 20, 2017
Member
|
New release is now on CPAN. |
goetzk
added a commit
to UniTasLibrary/DataCiteDoi
that referenced
this pull request
Aug 30, 2018
Work in progress code to change from LWP to WWW::Curl. This has been forced upon us by the age of LWP in RHEL6.10 which can't handle SNI servers. See also curl/curl#700 - Curl updates in RHEL 6.7 and 6.8 libwww-perl/LWP-Protocol-https#17 LWP SNI fix from 6.07
goetzk
added a commit
to eprintsug/DataCiteDoi
that referenced
this pull request
Oct 4, 2018
Offer WWW::Curl as an option for API connections The cause of this development was the age of LWP in RHEL6.10 can't handle SNI servers - used by DataCite for their API. For more on the LWP age issue and curl updates which ensure it works see these issues. libwww-perl/LWP-Protocol-https#17 LWP SNI fix from 6.07 curl/curl#700 - Curl updates in RHEL 6.7 and 6.8 This branch/change allows curl to be used opt in, defaulting to LWP, and should not change any existing behaviours (those breaking changes were in #23 and #33). There are also some other changes which have come through as I've tried to keep various files (like configuration and README) in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes IO::Socket::SSL fails to detect the proper hostname for SNI from PeerHost inside start_SSL.
This way the name is explicitly given. This fixes issue libwww-perl/libwww-perl#57.