build: Move to UI library, remove unused stuff#102
Merged
stanleyjones merged 4 commits intoliftedinit:mainfrom Dec 7, 2022
Merged
build: Move to UI library, remove unused stuff#102stanleyjones merged 4 commits intoliftedinit:mainfrom
stanleyjones merged 4 commits intoliftedinit:mainfrom
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
stanleyjones
changed the title
mjsorribas
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of the efforts begun in liftedinit/gwen#13 and liftedinit/kaylee#4 to move all of our apps to a shared UI library.
shared/*to@liftedinit/uiAssetSelector,Layout) out of shared directorysrc/shared/and/src/features/auth)package.json(remove unused packages, movedevDependenciesto the correct place)Testing / Breaking Changes
Build, unit tests, and e2e tests all pass. Visually inspected manually (and made a couple changes).
There should be no breaking changes.
Screenshots
BEFORE
AFTER
You may notice that this PR changes the default font from Roboto back to Rubik. This change is intended.