fix: Use Memo type to submit/display multi-sig transactions#110
Merged
stanleyjones merged 12 commits intoliftedinit:mainfrom Mar 1, 2023
Merged
fix: Use Memo type to submit/display multi-sig transactions#110stanleyjones merged 12 commits intoliftedinit:mainfrom
stanleyjones merged 12 commits intoliftedinit:mainfrom
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
stanleyjones
changed the title
hansl
reviewed
Mar 1, 2023
stanleyjones
commented
Mar 1, 2023
| const { memo, executeAutomatically, threshold, transaction, submitter } = | ||
| (multisigTxnInfoData?.info ?? {}) as MultisigTransactionInfo | ||
|
|
||
| const memoStr = memo && typeof memo[0] === "string" ? memo[0] : "" |
Contributor
Author
There was a problem hiding this comment.
I could also do a map here. Depends on how many human-readable memos we expect transactions to have.
Contributor
There was a problem hiding this comment.
Just the 1 from the UI for now so I think that's fine.
Contributor
Author
|
Tested with alberto.liftedinit.dev and seems to be working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also see liftedinit/many-js#96
Fixes #109