fix: multisig tx details#124
Merged
fmorency merged 1 commit intoliftedinit:mainfrom Jul 26, 2023
Merged
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgryffindor
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieve multisig transaction details from current and legacy networks.
This PR support
Nlegacy networks.Any multisig transaction in a pending state on a legacy network will need to be re-created on the new network. Those pending multisig will remain pending indefinitely, as we do not want to modify the legacy storage.
Future work:
I also did some small refactoring.
@stanleyjones is there a reason why we're not using more native many-js types in Alberto, e.g., we're using
stringinstead ofMultisigTransactionState. I saw this behavior often in Gwen/Alberto and was wondering what the reason was.