style: Responsive containers#137
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const [, setContainerProps] = usePageContainerProvider() | ||
|
|
||
| React.useLayoutEffect(() => { | ||
| setContainerProps({ | ||
| w: { base: "full" }, | ||
| }) | ||
| }, [setContainerProps]) |
There was a problem hiding this comment.
This didn't seem to be doing anything. We don't even use PageContainer on Home so it may not have been fully implemented or something.
| <Container | ||
| maxW={{ | ||
| base: "auto", | ||
| md: "container.sm", | ||
| lg: "container.md", | ||
| xl: "container.lg", | ||
| }} | ||
| > |
There was a problem hiding this comment.
Swapping in a Container for a PageContainer and adding the responsive sizes is the only change on this page. The rest is just formatting.
| <Container | ||
| maxW={{ | ||
| base: "auto", | ||
| md: "container.sm", | ||
| lg: "container.md", | ||
| xl: "container.lg", | ||
| }} | ||
| > |
There was a problem hiding this comment.
The Home page was artificially limited to "container.sm" size. Now it scales up with the display.
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 33.84% 33.93% +0.08%
==========================================
Files 88 88
Lines 2266 2260 -6
Branches 656 656
==========================================
Hits 767 767
+ Misses 1488 1482 -6
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@stanleyjones is this ready for review? |
|
@fmorency Yes. Sorry, I forgot to request a review. I'll add you now. |
|
Oh weird, I can't modify reviewers or assignee. That must be why I didn't. |
2 participants
HOME-SMALL
HOME-MEDIUM
(Scales all the way up to "XL")
Closes #132.
ACCOUNTS
(Same thing, only screenshot included here.)
Closes #133.