Skip to content

feat: token create event handling and txn history improvements#145

Merged
fmorency merged 12 commits intoliftedinit:mainfrom
fmorency:fix-txn-rendering
Oct 2, 2023
Merged

feat: token create event handling and txn history improvements#145
fmorency merged 12 commits intoliftedinit:mainfrom
fmorency:fix-txn-rendering

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

@fmorency fmorency commented Sep 29, 2023

  • Handle listing token create events
  • Better caching of the transaction history list (useQuery)

I tested the feature on the local network.

Requires liftedinit/many-js#116

@fmorency fmorency self-assigned this Sep 29, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 29, 2023

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 395d63b
🔍 Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/651ae2d3b9cc700009eb44d8
😎 Deploy Preview https://deploy-preview-145--lifted-alberto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2023

Codecov Report

Merging #145 (395d63b) into main (17507f0) will decrease coverage by 0.58%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   34.43%   33.85%   -0.58%     
==========================================
  Files          88       89       +1     
  Lines        2262     2280      +18     
  Branches      654      654              
==========================================
- Hits          779      772       -7     
- Misses       1472     1497      +25     
  Partials       11       11              
Files Coverage Δ
...ures/transactions/components/txn-list/txn-list.tsx 87.50% <100.00%> (+5.14%) ⬆️
src/views/home/asset-details/asset-details.tsx 66.66% <ø> (ø)
.../views/transaction-details/transaction-details.tsx 0.00% <0.00%> (ø)
src/features/network/queries.ts 20.00% <0.00%> (+1.48%) ⬆️
...omponents/txn-list/txn-list-item/txn-list-item.tsx 16.66% <0.00%> (-1.52%) ⬇️
...-list/txn-list-item/token-create-txn-list-item.tsx 0.00% <0.00%> (ø)
...actions/components/txn-list/txn-list-item/hooks.ts 13.08% <0.00%> (-0.92%) ⬇️
src/features/transactions/queries.ts 43.42% <49.20%> (-18.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmorency fmorency marked this pull request as ready for review September 29, 2023 18:55
@fmorency
Copy link
Copy Markdown
Contributor Author

@jgryffindor can you deploy this in QA for testing, please?

Copy link
Copy Markdown

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and tested in QA

@fmorency fmorency merged commit 2f78a30 into liftedinit:main Oct 2, 2023
@fmorency fmorency deleted the fix-txn-rendering branch October 2, 2023 15:38
@fmorency fmorency mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants