Skip to content

feat: transaction history exporter#146

Merged
fmorency merged 8 commits intoliftedinit:mainfrom
fmorency:txs-history-exporter
Dec 6, 2023
Merged

feat: transaction history exporter#146
fmorency merged 8 commits intoliftedinit:mainfrom
fmorency:txs-history-exporter

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

@fmorency fmorency commented Oct 6, 2023

  • Track source network of every transaction, improving efficiency when multiple backends are used
  • Export history to a CSV file with the following fields
    • id: encoded transaction ID
    • date: transaction (local) date
    • time: transaction (local) time
    • type: transaction type
    • from: funds were taken from this account
    • to: funds were moved to this account
    • amount: the amount transfered
    • symbol: the token symbol used for the transaction
  • send, mint and burn are supported, including transactions executed via multisig

Fixes #143

@fmorency fmorency self-assigned this Oct 6, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2023

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 9c4c9c2
🔍 Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/6570d464c881260008bb8d56
😎 Deploy Preview https://deploy-preview-146--lifted-alberto.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 6, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (e9f0eb5) 34.27% compared to head (9c4c9c2) 35.10%.

Files Patch % Lines
...ions/components/txn-list/txn-export/txn-export.tsx 18.86% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   34.27%   35.10%   +0.82%     
==========================================
  Files          89       90       +1     
  Lines        2340     2396      +56     
  Branches      665      683      +18     
==========================================
+ Hits          802      841      +39     
- Misses       1527     1544      +17     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency marked this pull request as ready for review October 6, 2023 19:57
@fmorency
Copy link
Copy Markdown
Contributor Author

fmorency commented Oct 6, 2023

I'm not sure about the UI side of things but this PR should get the ball rolling. Happy to get your feedback.

Copy link
Copy Markdown
Contributor

@stanleyjones stanleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally had a chance to review this one. I tried it on the Lifted Treasury and it didn't export as many transactions as I expected but it looks like the transaction history has changed (only goes back to August) and this only exports send not all the the multi-sig stuff, so it's working as expected.

@fmorency fmorency merged commit 27fb842 into liftedinit:main Dec 6, 2023
@fmorency fmorency deleted the txs-history-exporter branch December 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction history exporter

2 participants