Skip to content

fix: big number handling#161

Merged
fmorency merged 2 commits intoliftedinit:mainfrom
fmorency:fix-bigint
Mar 12, 2024
Merged

fix: big number handling#161
fmorency merged 2 commits intoliftedinit:mainfrom
fmorency:fix-bigint

Conversation

@fmorency
Copy link
Copy Markdown
Contributor

@fmorency fmorency commented Mar 12, 2024

Depends on liftedinit/lifted-ui#28

Fixes how big numbers are handled. Huge transaction amounts should be handled properly now.

@fmorency fmorency added the bug Something isn't working label Mar 12, 2024
@fmorency fmorency requested a review from jgryffindor March 12, 2024 18:08
@fmorency fmorency self-assigned this Mar 12, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 12, 2024

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit 0caefac
🔍 Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/65f0ae600f8481000891666c
😎 Deploy Preview https://deploy-preview-161--lifted-alberto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 35.10%. Comparing base (9945a2e) to head (0caefac).

Files Patch % Lines
.../transactions/components/send-asset/send-asset.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files          90       90           
  Lines        2396     2396           
  Branches      683      683           
=======================================
  Hits          841      841           
  Misses       1544     1544           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@fmorency fmorency merged commit 8d6725f into liftedinit:main Mar 12, 2024
@fmorency fmorency deleted the fix-bigint branch March 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants