Skip to content

Ian/fix memory issue in xed #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2over12 merged 2 commits into from
Jan 24, 2022
Merged

Ian/fix memory issue in xed #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5475ced
added memory fix patch
2over12 Jan 22, 2022
51c5041
fix format
2over12 Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ports/xed/dont_call_evex_scan_when_error.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/src/dec/xed-ild.c b/src/dec/xed-ild.c
index 1960b4e..6ba91cd 100644
--- a/src/dec/xed-ild.c
+++ b/src/dec/xed-ild.c
@@ -1447,7 +1447,7 @@ xed_instruction_length_decode(xed_decoded_inst_t* ild)
#if defined(XED_SUPPORTS_AVX512) || defined(XED_SUPPORTS_KNC)

// evex scanner assumes it can read bytes so we must check for limit first.
- if (xed3_operand_get_out_of_bytes(ild))
+ if (xed3_operand_get_out_of_bytes(ild) || xed3_operand_get_error(ild))
return;

// if we got a vex prefix (which also sucks down the opcode),
2 changes: 2 additions & 0 deletions ports/xed/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ vcpkg_from_github(
REF 5976632eeaaaad7890c2109d0cfaf4012eaca3b8 # 12.0.1
SHA512 9463e669cc273f55829e82d6032763221c2ba73f3c43191be847f694f6fd3609b866cc14101e8b1f88e7e44f04b4f5f7bf61bb9431b72b7e17ded1db34b7757d
HEAD_REF master
PATCHES
dont_call_evex_scan_when_error.patch
)

# Last checked Dec 9, 2020
Expand Down