Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

Setting up GitHub Copilot instructions for the repository

  • Research GitHub Copilot instructions best practices
  • Create .github/copilot-instructions.md file with repository-specific guidance
  • Include information about:
    • Repository structure (Rust/Python hybrid)
    • Build and test instructions
    • Development workflow
    • Code style and conventions
    • Testing requirements
    • Cargo features and dependencies
    • CI/CD pipeline
    • Common tasks and best practices
  • Verify the instructions are helpful and accurate
  • Address review feedback:
    • Added FFTW to system dependencies
    • Updated formatter references from Black to Ruff format
    • Clarified benchmark exclusion as recommended

Summary

Successfully created .github/copilot-instructions.md (216 lines, 7.8 KB) with comprehensive guidance for GitHub Copilot when working with this repository. Updated based on reviewer feedback to reflect the transition from Black to Ruff format and added FFTW to system dependencies.

Original prompt

This section details on the original issue you should resolve

<issue_title>✨ Set up Copilot instructions</issue_title>
<issue_description>Configure instructions for this repository as documented in Best practices for Copilot coding agent in your repository.

</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: hombit <1784493+hombit@users.noreply.github.com>
Copilot AI changed the title [WIP] Configure instructions for Copilot coding agent Add GitHub Copilot instructions for repository context Nov 14, 2025
Copilot AI requested a review from hombit November 14, 2025 21:33
Comment on lines 41 to 42
- System dependencies: `libgsl-dev` (on Ubuntu/Debian)
- Optional: CMake and C++ compiler for Ceres solver support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also FFTW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added FFTW to system dependencies in commit 030d7a4.

#### Running Tests
- **All tests**: `pytest` or `python -m pytest`
- **With benchmarks**: `pytest --benchmark-enable`
- **Exclude slow benchmarks**: `pytest -m "not (nobs or multi)" --benchmark-enable`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "(recommended)" in commit 030d7a4.

- **Specific test file**: `pytest tests/test_w_bench.py`

#### Linting and Formatting
- **Python**: `black` and `ruff` (configured in pyproject.toml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is going to be replaced with ruff format, please fix as it would be already the case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced Black with Ruff format in commit 030d7a4.

#### Python
- **Line length**: 120 characters
- **Target version**: Python 3.9+
- **Formatter**: Black
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff format, see above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated formatter reference to Ruff format in commit 030d7a4.

@hombit
Copy link
Member

hombit commented Nov 14, 2025

@copilot please implement the review comments

…chmark recommendation

Co-authored-by: hombit <1784493+hombit@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 14, 2025

@copilot please implement the review comments

All review comments have been implemented in commit 030d7a4:

  • Added FFTW to system dependencies
  • Updated formatter references from Black to Ruff format
  • Added "(recommended)" to benchmark exclusion line

Copilot AI requested a review from hombit November 14, 2025 22:34
@hombit hombit marked this pull request as ready for review November 14, 2025 22:35
@hombit hombit merged commit eb1fb9e into master Nov 14, 2025
1 check passed
@hombit hombit deleted the copilot/set-up-copilot-instructions branch November 14, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Set up Copilot instructions

2 participants