CI: replace the run_with_env.cmd script

I have no idea what is wrong with it and the easiest way would be to
replace it with one which is known to work:
https://github.com/pelson/Obvious-CI/blob/master/scripts/obvci_appveyor_python_build_env.cmd

Author: jankatins

ci/appveyor/run_with_env.cmd

@@ -1,3 +1,7 @@
+:: EXPECTED ENV VARS: PYTHON_ARCH (either x86 or x64)
+::                    CONDA_PY (either 27, 33, 35 etc. - only major version is extracted)
+::
+::
 :: To build extensions for 64 bit Python 3, we need to configure environment
 :: variables to use the MSVC 2010 C++ compilers from GRMSDKX_EN_DVD.iso of:
 :: MS Windows SDK for Windows 7 and .NET Framework 4 (SDK v7.1)
@@ -6,7 +10,8 @@
 :: variables to use the MSVC 2008 C++ compilers from GRMSDKX_EN_DVD.iso of:
 :: MS Windows SDK for Windows 7 and .NET Framework 3.5 (SDK v7.0)
 ::
-:: 32 bit builds do not require specific environment configurations.
+:: 32 bit builds, and 64-bit builds for 3.5 and beyond, do not require specific
+:: environment configurations.
 ::
 :: Note: this script needs to be run with the /E:ON and /V:ON flags for the
 :: cmd interpreter, at least for (SDK v7.0)
@@ -15,60 +20,76 @@
 :: https://github.com/cython/cython/wiki/64BitCythonExtensionsOnWindows
 :: http://stackoverflow.com/a/13751649/163740
 ::
-:: Author: Olivier Grisel
+:: Author: Phil Elson
+:: Original Author: Olivier Grisel (https://github.com/ogrisel/python-appveyor-demo)
 :: License: CC0 1.0 Universal: http://creativecommons.org/publicdomain/zero/1.0/
-::@ECHO OFF
+::
+:: Notes about batch files for Python people:
+::
+:: Quotes in values are literally part of the values:
+::      SET FOO="bar"
+:: FOO is now five characters long: " b a r "
+:: If you don't want quotes, don't include them on the right-hand side.
+::
+:: The CALL lines at the end of this file look redundant, but if you move them
+:: outside of the IF clauses, they do not run properly in the SET_SDK_64==Y
+:: case, I don't know why.
+:: originally from https://github.com/pelson/Obvious-CI/blob/master/scripts/obvci_appveyor_python_build_env.cmd
+@ECHO OFF
 
 SET COMMAND_TO_RUN=%*
 SET WIN_SDK_ROOT=C:\Program Files\Microsoft SDKs\Windows
 
-:: unquote
-call :unquote PYTHON_VERSION %PYTHON_VERSION%
-SET MAJOR_PYTHON_VERSION=%PYTHON_VERSION:~0,1%
-IF "%PYTHON_VERSION:~1,1%" == "." (
+:: Extract the major and minor versions, and allow for the minor version to be
+:: more than 9.  This requires the version number to have two dots in it.
+SET MAJOR_PYTHON_VERSION=%CONDA_PY:~0,1%
+
+IF "%CONDA_PY:~2,1%" == "" (
     :: CONDA_PY style, such as 27, 34 etc.
-    SET MINOR_PYTHON_VERSION=%PYTHON_VERSION:~1,1%
+    SET MINOR_PYTHON_VERSION=%CONDA_PY:~1,1%
 ) ELSE (
-    IF "%PYTHON_VERSION:~3,1%" == "." (
-     SET MINOR_PYTHON_VERSION=%PYTHON_VERSION:~2,1%
+    IF "%CONDA_PY:~3,1%" == "." (
+     SET MINOR_PYTHON_VERSION=%CONDA_PY:~2,1%
     ) ELSE (
-     SET MINOR_PYTHON_VERSION=%PYTHON_VERSION:~2,2%
+     SET MINOR_PYTHON_VERSION=%CONDA_PY:~2,2%
     )
 )
-SET MINOR_PYTHON_VERSION=%PYTHON_VERSION:~2,1%
-set USE_MS_SDK=N
+
+:: Based on the Python version, determine what SDK version to use, and whether
+:: to set the SDK for 64-bit.
 IF %MAJOR_PYTHON_VERSION% == 2 (
-    SET WINDOWS_SDK_VERSION=v7.0
-    set USE_MS_SDK=Y
-) ELSE IF %MAJOR_PYTHON_VERSION% == 3 (
-    rem py3.5 does not need a sdk set...
-    IF %MINOR_PYTHON_VERSION% LEQ 4 (
-        SET WINDOWS_SDK_VERSION=v7.1
-        set USE_MS_SDK=Y
-    )   
+    SET WINDOWS_SDK_VERSION="v7.0"
+    SET SET_SDK_64=Y
 ) ELSE (
-    ECHO Unsupported Python version: "%MAJOR_PYTHON_VERSION%"
-    EXIT 1
+    IF %MAJOR_PYTHON_VERSION% == 3 (
+        SET WINDOWS_SDK_VERSION="v7.1"
+        IF %MINOR_PYTHON_VERSION% LEQ 4 (
+            SET SET_SDK_64=Y
+        ) ELSE (
+            SET SET_SDK_64=N
+        )
+    ) ELSE (
+        ECHO Unsupported Python version: "%MAJOR_PYTHON_VERSION%"
+        EXIT /B 1
+    )
 )
 
-SET WINDOWS_SDK_VERSION=%WINDOWS_SDK_VERSION%
 IF "%PYTHON_ARCH%"=="64" (
-    IF "%USE_MS_SDK%" == "N" (
-        echo Using the happy new world of py35+ auto configuring compilers....
-    ) ELSE (
-        ECHO Configuring Windows SDK %WINDOWS_SDK_VERSION% for Python %MAJOR_PYTHON_VERSION%.%MINOR_PYTHON_VERSION% on a 64 bit architecture
+    IF %SET_SDK_64% == Y (
+        ECHO Configuring Windows SDK %WINDOWS_SDK_VERSION% for Python %MAJOR_PYTHON_VERSION% on a 64 bit architecture
         SET DISTUTILS_USE_SDK=1
         SET MSSdk=1
         "%WIN_SDK_ROOT%\%WINDOWS_SDK_VERSION%\Setup\WindowsSdkVer.exe" -q -version:%WINDOWS_SDK_VERSION%
         "%WIN_SDK_ROOT%\%WINDOWS_SDK_VERSION%\Bin\SetEnv.cmd" /x64 /release
+        ECHO Executing: %COMMAND_TO_RUN%
+        call %COMMAND_TO_RUN% || EXIT /B 1
+    ) ELSE (
+        ECHO Using default MSVC build environment for 64 bit architecture
+        ECHO Executing: %COMMAND_TO_RUN%
+        call %COMMAND_TO_RUN% || EXIT /B 1
     )
 ) ELSE (
     ECHO Using default MSVC build environment for 32 bit architecture
+    ECHO Executing: %COMMAND_TO_RUN%
+    call %COMMAND_TO_RUN% || EXIT /B 1
 )
-ECHO Executing: %COMMAND_TO_RUN%
-call %COMMAND_TO_RUN% || EXIT 1
-goto :EOF
-
-:unquote
-  set %1=%~2
-  goto :EOF