Skip to content

Conversation

@jcracknell
Copy link
Contributor

The interpolation destructuring added in 3.6.0 attempts to convert interpolated messages to slf4j message formatting calls. These have signature (String, Object*)Unit, and as such any interpolations involving value types result in compilation errors. The simplest fix I came up with for this is to invoke toString on such interpolations, as they cannot be null.

The implementation also doesn't escape {} appearing in string parts, and doesn't account for Scala's wonky escape handling for interpolators.

@lightbend-cla-validator
Copy link
Collaborator

Hi @jcracknell,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://www.lightbend.com/contribute/cla

Box interpolated values for consistency in testing and to avoid runtime
checks for expressions of type Any.
@analytically analytically merged commit 87e8407 into lightbend-labs:master Jul 4, 2017
@analytically
Copy link
Collaborator

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants