Fix docs & sanity check Scala version coherence #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new sbt-scalafix 0.9.18 release includes a
scalafixScalaBinaryVersion key that can be used to run, for instance,
the Scalafix for Scala 2.13 when running against sources compiled with
2.13.
Add those instructions to the README. The nice thing is this new
version and setting can be used the releases scala-rewrites 0.1.0.
But also add a sanity check to ExplicitNonNullaryApply (continuing to
copy from Scalafix's ExplicitResultTypes), with some fixing tips. This
is what it looks like on a test project:
[error] (scalafixAll) scalafix.sbt.InvalidArgument: Scala version mismatch:
(1) the target sources were compiled with Scala 2.13.2; (2) Scalafix is
running on Scala 2.12.11. To fix make scalafixScalaBinaryVersion == 2.13.
Try `ThisBuild / scalafixScalaBinaryVersion :=
CrossVersion.binaryScalaVersion(scalaVersion.value)`.
Also switch the docs to scalafixAll, and prep for a 0.1.1 release.
Contributor
|
Nice README! Also, that shows that scalafix-core should provide some plumbing so that advanced rules authors don't need to replicate what |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new sbt-scalafix 0.9.18 release includes a
scalafixScalaBinaryVersion key that can be used to run, for instance,
the Scalafix for Scala 2.13 when running against sources compiled with
2.13.
Add those instructions to the README. The nice thing is this new
version and setting can be used the releases scala-rewrites 0.1.0.
But also add a sanity check to ExplicitNonNullaryApply (continuing to
copy from Scalafix's ExplicitResultTypes), with some fixing tips. This
is what it looks like on a test project:
Also switch the docs to scalafixAll, and prep for a 0.1.1 release.
Fixes #43