Review. #1
Closed
Review. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now mostly syntactic and conventions.
I only changed some of the camlCase to kebab-case.
There are a lot of explicit `yield` calls. Not clear if all of them
are needed.
Logging with `tags` is usually the preferred way.
String-interpolation is your friend. (Also calls `.stringify`
automatically).
Missing toitdocs. They should be there at least for public elements.
A few too many abbreviatons.
addshore
added a commit
that referenced
this pull request
Mar 18, 2025
Extracted from: #1 Co-authored-by: Florian Loitsch <florian@loitsch.com>
addshore
added a commit
that referenced
this pull request
Mar 18, 2025
Extracted from: #1 Co-authored-by: Florian Loitsch <florian@loitsch.com>
addshore
added a commit
that referenced
this pull request
Mar 18, 2025
Extracted from: #1 Co-authored-by: Florian Loitsch <florian@loitsch.com>
addshore
added a commit
that referenced
this pull request
Mar 18, 2025
Extracted from: #1 Co-authored-by: Florian Loitsch <florian@loitsch.com>
addshore
added a commit
that referenced
this pull request
Mar 18, 2025
Extracted from: #1 Co-authored-by: Florian Loitsch <florian@loitsch.com>
Member
|
Thanks for the review, I have folded as much of this in as possible for now |
addshore
added a commit
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now mostly syntactic and conventions.
I only changed some of the camlCase to kebab-case.
There are a lot of explicit
yieldcalls. Not clear if all of themare needed.
Logging with
tagsis usually the preferred way.String-interpolation is your friend. (Also calls
.stringifyautomatically).
Missing toitdocs. They should be there at least for public elements.
A few too many abbreviatons.