feat: save chart in dashboard

[ZeRego]

Relates to: #6133
Closes: #6227

Description:

Changes:

• amend knex table typing
• update chart table to have a dashboard uuid column and space id column be nullable

Table before:

create table saved_queries
(
    saved_query_id                    integer generated always as identity
        primary key,
    saved_query_uuid                  uuid         default uuid_generate_v4() not null
        constraint saved_queries_saved_query_uuid_unique
            unique,
    created_at                        timestamp    default CURRENT_TIMESTAMP  not null,
    name                              text                                    not null,
    space_id                          integer                                 not null
        constraint saved_queries_space_id_foreign
            references spaces
            on delete cascade,
    description                       text,
    last_version_chart_kind           varchar(255) default 'vertical_bar'::character varying,
    last_version_updated_at           timestamp    default CURRENT_TIMESTAMP,
    last_version_updated_by_user_uuid uuid
        constraint saved_queries_last_version_updated_by_user_uuid_foreign
            references users (user_uuid)
            on delete set null
);

Table now:

create table saved_queries
(
    saved_query_id                    integer generated always as identity
        primary key,
    saved_query_uuid                  uuid         default uuid_generate_v4() not null
        constraint saved_queries_saved_query_uuid_unique
            unique,
    created_at                        timestamp    default CURRENT_TIMESTAMP  not null,
    name                              text                                    not null,
    space_id                          integer
        constraint saved_queries_space_id_foreign
            references spaces
            on delete cascade,
    description                       text,
    last_version_chart_kind           varchar(255) default 'vertical_bar'::character varying,
    last_version_updated_at           timestamp    default CURRENT_TIMESTAMP,
    last_version_updated_by_user_uuid uuid
        constraint saved_queries_last_version_updated_by_user_uuid_foreign
            references users (user_uuid)
            on delete set null,
    dashboard_uuid                    uuid
        constraint saved_queries_dashboard_uuid_foreign
            references dashboards (dashboard_uuid)
            on delete cascade
);

E2e test passing:

Preview:

Dashboards.-.Lightdash.-.18.July.2023.mp4

[netlify]

✅ Deploy Preview for peaceful-bassi-cbf284 canceled.

Name	Link
🔨 Latest commit	5a74a33
🔍 Latest deploy log	https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/64ba4f1a022c340008e9af0e

[ZeRego]

We are going to support preview content in a following PR

[rephus]

This branch has not been deployed

Can we get this in render ?

[ZeRego]

knex migrate:rollback is to rollback the last batch of migrations. eg: If you migrated everything in 1 go, it would rollback everything.

We just want to rollback the last migration script.

[rephus]

Do we have this API dashboard twice because we run e2e tests twice ?

perhaps we want to delete it "at the beggining" of a new e2e test

[rephus]

I can't edit the title or the content of a chart in dashboard

[rephus]

I haven't tested scheduled delivieres for these charts, but I can see they can be previewed on /minimal, so I assume they work

[rephus]

Interesting behaviour on these chart in dashboard options:

• save chart as: creates a new chat that doens't belong to a dashboard, so it is browsable (kind of expected)
• add to dashboard: you can add this chart to another dashboard, but I guess this will be deleted as well if the original dashboard gets deleted.
• move to space: errors (tries to update the chart, see previous comment)

[rephus]

I think the only thing we need to fix is the ability to update chart in dashboards. Everything else seems ok, or not a blocker.

[ZeRego]

@rephus

Do we have this API dashboard twice because we run e2e tests twice ?

This may happen when the test retries.

perhaps we want to delete it "at the beggining" of a new e2e test

We already delete these dashboards and charts at the beginning of the tests.

I can't edit the title or the content of a chart in dashboard

Fixed chart summary query and added test.

Interesting behaviour on these chart in dashboard options:

We have tickets in the milestone to disable some of these options. Shouldn't be an issue while the feature is under a feature flag.

[rephus]

Everything works now. I'm happy about your comments.

Just 1 minor bug, we can fix it on a separate PR, or even disable the move to space option int he UI branch

If I move a chart in dashboard into another space (which doesn't make sense anyway) , the chart becomes "visible"

[ZeRego]

If I move a chart in dashboard into another space (which doesn't make sense anyway) , the chart becomes "visible"

We will have the option to move charts from dashboards to the space. The BE will set the dashboard to null in that case. In your case we set the space uuid but didn't set the dashboarduuid to null causing that problem.

[lightdash-bot]

🎉 This PR is included in version 0.685.0 🎉

The release is available on:

• 0.685.0
• GitHub release

Your semantic-release bot 📦🚀