chore: upgrade styleguidist #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this customization stuff part of the new styleguidist or was that already possible before? |
|
Was already possible before I guess, but I didn't want to do it before I upgrade the styleguidist as well. |
frabbit
suggested changes
Aug 27, 2019
styleguide/ComponentsList.js
Outdated
| <li key={href}> | ||
| <a | ||
| className={classnames( | ||
| 'olt-Link', |
There was a problem hiding this comment.
let's use variables here: oltStyles.Link
styleguide/Markdown/Pre.js
Outdated
| const PreRenderer = ({ className, children }) => { | ||
| const isHighlighted = className && className.indexOf('lang-') !== -1; | ||
| return ( | ||
| <div className="olt-Card pre--wrapper"> |
There was a problem hiding this comment.
let's use variables here: oltStyles.Card
There was a problem hiding this comment.
or the Card component directly
There was a problem hiding this comment.
Good catch. I replaced it with Card component.
styleguide/Markdown/Pre.js
Outdated
| const isHighlighted = className && className.indexOf('lang-') !== -1; | ||
| return ( | ||
| <div className="olt-Card pre--wrapper"> | ||
| <div className="olt-Card-content"> |
There was a problem hiding this comment.
let's use variables here: oltStyles.CardContent
|
It looks great in general, just a few tiny notes. |
frabbit
approved these changes
Aug 28, 2019
JonathanStoye
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.