feat: v2 dropdown #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumendorf
suggested changes
Nov 19, 2019
| }); | ||
| const itemFoo = getByText('Item Foo'); | ||
| const itemBar = getByText('Item Bar'); | ||
| expect(itemFoo.classList.contains('is-active')).toBeTruthy(); |
There was a problem hiding this comment.
Might be better to use .toBe(true) if you are expecting this to actually be true?
| const itemFoo = getByText('Item Foo'); | ||
| const itemBar = getByText('Item Bar'); | ||
| expect(itemFoo.classList.contains('is-active')).toBeTruthy(); | ||
| expect(itemBar.classList.contains('is-active')).toBeFalsy(); |
|
|
||
| ```jsx | ||
| import { InputList, InputListItem } from '@lightelligence/react'; | ||
| const onClick = (value) => { |
There was a problem hiding this comment.
Suggested change
| const onClick = (value) => { | |
| const onChange = (value) => { |
| }); | ||
|
|
||
| const component = getByText('Component'); | ||
| expect(component.classList.contains('myClass')).toBeTruthy(); |
There was a problem hiding this comment.
Suggested change
| expect(component.classList.contains('myClass')).toBeTruthy(); | |
| expect(component.classList.contains('myClass')).toBe(true); |
| {selectedElement.props.children} | ||
| </div> | ||
| )} | ||
| <div className={classnames(olt.V2DropdownContent)}> |
There was a problem hiding this comment.
The dropdown content is rendered behind the code field in the guide.
| ], | ||
| }); | ||
| const component = getByTestId('component'); | ||
| expect(component.classList.contains('myClass')).toBeTruthy(); |
There was a problem hiding this comment.
Suggested change
| expect(component.classList.contains('myClass')).toBeTruthy(); | |
| expect(component.classList.contains('myClass')).toBe(true); |
| }); | ||
| const component = getByTestId('component'); | ||
| fireEvent.click(component); | ||
| expect(component.classList.contains('is-open')).toBeTruthy(); |
There was a problem hiding this comment.
Suggested change
| expect(component.classList.contains('is-open')).toBeTruthy(); | |
| expect(component.classList.contains('is-open')).toBe(true); |
| fireEvent.click(component); | ||
| expect(component.classList.contains('is-open')).toBeTruthy(); | ||
| fireEvent.click(component); | ||
| expect(component.classList.contains('is-open')).toBeFalsy(); |
There was a problem hiding this comment.
Suggested change
| expect(component.classList.contains('is-open')).toBeFalsy(); | |
| expect(component.classList.contains('is-open')).toBe(false); |
| ); | ||
| const selectedElement = selectedChild && React.cloneElement(selectedChild); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
There are a couple of components that allow passing props to their children (e.g. Card with contentProps, actionProps, headerProps, editProps, ...) should we allow that consistently for all components?
blumendorf
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.