Skip to content

Feature(v3) refactored zIndexing #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfboeve wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feature(v3) refactored zIndexing #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
945a64f
initial check in
jfboeve Nov 11, 2025
eff689f
changed UpdateType enum
jfboeve Nov 19, 2025
05d36ba
optimized zindex sorting
jfboeve Nov 20, 2025
a5ce760
revert get id back to previous setup
jfboeve Nov 20, 2025
5ae5dd7
revert radius settings in test
jfboeve Nov 21, 2025
1de7fe6
improved sorting by zIndex
jfboeve Nov 24, 2025
76f78d7
fixed bucket sorting, introduced max zIndex 1000, min zIndex -1000
jfboeve Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 13 additions & 29 deletions examples/tests/zIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
//@ts-ignore
color: Colors[color],
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
zIndex: 10 + (i + 1),
Expand All @@ -81,12 +81,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 600,
h: 600,
color: Colors.Gray,
// shader: renderer.createShader('RoundedRectangle', {
// shader: renderer.createShader('Rounded', {
// radius: 40,
// }),
zIndex: 2,
parent: testRoot,
zIndexLocked: 1,
});

const childRectWhite = renderer.createNode({
Expand All @@ -95,7 +94,7 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 200,
h: 200,
color: Colors.White,
// shader: renderer.createShader('RoundedRectangle', {
// shader: renderer.createShader('Rounded', {
// radius: 40,
// }),
zIndex: 4,
Expand All @@ -108,7 +107,7 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 200,
h: 200,
color: Colors.Red,
// shader: renderer.createShader('RoundedRectangle', {
// shader: renderer.createShader('Rounded', {
// radius: 40,
// }),
zIndex: 5,
Expand Down Expand Up @@ -136,7 +135,7 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 400,
h: 100,
color: Colors.Green,
// shader: renderer.createShader('RoundedRectangle', {
// shader: renderer.createShader('Rounded', {
// radius: 40,
// }),
zIndex: 2,
Expand Down Expand Up @@ -164,13 +163,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),

zIndex: 148901482921849101841290481,

zIndexLocked: 148901482921849101841290481,
parent: testRoot,
});

Expand All @@ -180,13 +177,12 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),

zIndex: -148901482921849101841290481,

zIndexLocked: -148901482921849101841290481,
parent: testRoot,
});

Expand All @@ -196,13 +192,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
// @ts-expect-error Invalid prop test
zIndex: 'boop',
// @ts-expect-error Invalid prop test
zIndexLocked: 'boop',
parent: testRoot,
});

Expand All @@ -212,13 +206,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
// @ts-expect-error Invalid prop test
zIndex: true,
// @ts-expect-error Invalid prop test
zIndexLocked: true,
parent: testRoot,
});

Expand All @@ -228,13 +220,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
// @ts-expect-error Invalid prop test
zIndex: null,
// @ts-expect-error Invalid prop test
zIndexLocked: null,
parent: testRoot,
});

Expand All @@ -244,11 +234,10 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
zIndex: undefined,
zIndexLocked: undefined,
parent: testRoot,
});

Expand All @@ -258,15 +247,12 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
// @ts-expect-error Invalid prop test

zIndex: () => {},
// @ts-expect-error Invalid prop test

zIndexLocked: () => {},
parent: testRoot,
});

Expand All @@ -276,13 +262,11 @@ export default async function test({ renderer, testRoot }: ExampleSettings) {
w: 10,
h: 10,
color: 0x00ffffff,
shader: renderer.createShader('RoundedRectangle', {
shader: renderer.createShader('Rounded', {
radius: 2,
}),
// @ts-expect-error Invalid prop test
zIndex: {},
// @ts-expect-error Invalid prop test
zIndexLocked: {},
parent: testRoot,
});
}
1 change: 0 additions & 1 deletion src/core/CoreNode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ describe('set color()', () => {
x: 0,
y: 0,
zIndex: 0,
zIndexLocked: 0,
};

const clippingRect = {
Expand Down
Loading