Rework channel_reestablish requirements
#1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only contains cosmetic whitespace changes: statements weren't consistently aligned. I harmonized them as I find that it helps readability, especially with complex nested conditions.
It's hard to follow when requirements are scattered in too many sections.
Rework the `channel_reestablish` receiver requirements: we first handle all error cases, then specify what should be retransmitted.
28 tasks
28 tasks
26 tasks
26 tasks
25 tasks
26 tasks
28 tasks
26 tasks
28 tasks
28 tasks
29 tasks
28 tasks
30 tasks
27 tasks
25 tasks
23 tasks
24 tasks
24 tasks
22 tasks
20 tasks
20 tasks
20 tasks
20 tasks
21 tasks
19 tasks
22 tasks
21 tasks
21 tasks
21 tasks
21 tasks
22 tasks
25 tasks
23 tasks
23 tasks
22 tasks
23 tasks
22 tasks
23 tasks
21 tasks
20 tasks
20 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1049 which changes the requirements more in-depth. I recommend reviewing it commit-by-commit and using a markdown viewer.
I started from our code and rewrote the requirements based on that. I'm trying to more clearly express the fact that the only possible errors cases are:
errorand wait for them to force-close (unless the node operator steps in to manually force close)channel_reestablish, we should wait for them to either send anerror(if they want us to force-close), or reconnect and send a differentchannel_reestablish(if they've fixed their state backup)This is harder to express in spec than in code, I may have gotten it wrong or missed a case, so please spend some time carefully reviewing this!
This should close #934 once and for all 🎉