Add peer management overview #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tnull
reviewed
Sep 28, 2022
docs/overview/peer-management.md
Outdated
| - A [`ChannelManager`](https://docs.rs/lightning/*/lightning/ln/channelmanager/index.html) that enables it to notify peers when it wants to do things such as open channels. | ||
| - A [`P2PGossipSync`](https://docs.rs/lightning/*/lightning/routing/gossip/struct.P2PGossipSync.html) that understands when peers you are connected to send you gossip messages, enables you to forward messages, announce channel opens and more. | ||
|
|
||
| Since LDK knows nothing about your networking stack, you'll need to implement this module in order to connect to peers on the network. Provide LDK with raw TCP/IP socket data and the library will handle the rest for you. |
There was a problem hiding this comment.
nit: A bit unclear what this module refers to in this sentence. I believe the networking stack?
There was a problem hiding this comment.
Sorry for late response, updated
Co-authored-by: Elias Rohrer <dev@tnull.de>
Co-authored-by: Elias Rohrer <dev@tnull.de>
tnull
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview - https://deploy-preview-167--lightningdevkit.netlify.app/overview/peer-management/