-
Notifications
You must be signed in to change notification settings - Fork 63
linter: upgrade golangci-lint to v2
#190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
.golangci.bck.yml
Outdated
| @@ -0,0 +1,45 @@ | |||
| run: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the backup file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, forgot to delete it.
.golangci.yml
Outdated
| @@ -1,16 +1,9 @@ | |||
| version: "2" | |||
| run: | |||
| # timeout for analysis | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the timeout comment? Is there no corresponding config item for v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like the config still exists for v2, but we can disable it by not declaring it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 🎉
The migration was done via: golangci-lint migrate --skip-validation
This PR upgrades the linter to
golangci-lintto v2 and migrates the existing.golangci.ymlwithgolangci-lint migrate --skip-validationto the v2 format.