Skip to content

Conversation

@hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Aug 19, 2025

This PR upgrades the linter to golangci-lint to v2 and migrates the existing .golangci.yml with golangci-lint migrate --skip-validation to the v2 format.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@@ -0,0 +1,45 @@
run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the backup file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, forgot to delete it.

.golangci.yml Outdated
@@ -1,16 +1,9 @@
version: "2"
run:
# timeout for analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the timeout comment? Is there no corresponding config item for v2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like the config still exists for v2, but we can disable it by not declaring it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the comment

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

The migration was done via:
golangci-lint migrate --skip-validation
@guggero guggero merged commit 7e5d505 into lightninglabs:master Aug 20, 2025
5 checks passed
@hieblmi hieblmi deleted the bump-linter branch August 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants