Skip to content

docker: add default Dockerfile #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2020
Merged

docker: add default Dockerfile #16

merged 1 commit into from
Mar 28, 2020

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented Mar 27, 2020

Adds a simple Dockerfile. Result can be tested by pulling the image guggero/governator.

@guggero guggero requested a review from carlaKC March 27, 2020 08:24
carlaKC
carlaKC approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, LGTM 🐳

@carlaKC carlaKC merged commit cf4fc1f into master Mar 28, 2020
@guggero guggero deleted the dockerfile branch March 30, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@carlaKC carlaKC carlaKC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guggero @carlaKC