multi: faraday rename #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
reviewed
Mar 29, 2020
README.md
Outdated
| [](https://github.com/lightninglabs/faraday/blob/master/LICENSE) | ||
|
|
||
| The governator is an external service intended to be run in conjunction with the [lnd](https://github.com/lightningnetwork/lnd) implementation of the [Lightning Network](https://lightning.network). It queries LND for information about its existing channels and provides channel close recommendations if channels are under-performing. | ||
| The faraday is an external service intended to be run in conjunction with the [lnd](https://github.com/lightningnetwork/lnd) implementation of the [Lightning Network](https://lightning.network). It queries LND for information about its existing channels and provides channel close recommendations if channels are under-performing. |
README.md
Outdated
|
|
||
| ## Installation | ||
| A [Makefile](https://github.com/lightninglabs/governator/blob/master/Makefile) is provided. To install governator and al its dependencies, run: | ||
| A [Makefile](https://github.com/lightninglabs/faraday/blob/master/Makefile) is provided. To install faraday and al its dependencies, run: |
guggero
reviewed
Mar 30, 2020
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice, I like the name!
Found two forgotten references, looks good to me otherwise 💯
frdrpc/README.md
Outdated
| @@ -1,8 +1,8 @@ | |||
| gvrpc | |||
frdrpc/rpcserver.go
Outdated
| @@ -1,14 +1,14 @@ | |||
| // Package gvrpc contains the proto files, generated code and server logic | |||
guggero
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename le project of many names to faraday.
Changes isolated to a single commit, just search-and-replaced everything + regenerated protos.