This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Display blocks to maturity on channel detail view. #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
suggested changes
Mar 13, 2019
tanx
suggested changes
Mar 13, 2019
tanx
suggested changes
Mar 14, 2019
valentinewallace
force-pushed
the
show-force-close-time
branch
2 times, most recently
from
9df2e5a to
4f6ae20
Compare
tanx
suggested changes
Mar 15, 2019
src/view/channel-detail.js
Outdated
| <DetailField name="Time Til Available"> | ||
| {store.selectedChannel.timeTilAvailable} | ||
| </DetailField> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
Move this below statusLabel. Seems more natural to reading the time til available after the status.
test/unit/helper.spec.js
Outdated
|
|
||
| it('should show NaN for undefined', () => { | ||
| const time = helpers.getTimeTilAvailable(undefined); | ||
| expect(time, 'to equal', 'NaN days and NaN hours'); |
Contributor
There was a problem hiding this comment.
We should probably throw an Error for undefined. This should only happen if the api changed and blocksTilMaturity isn't set as expected. And we wanna get notified in that case.
tanx
suggested changes
Mar 16, 2019
tanx
force-pushed
the
show-force-close-time
branch
from
fa514af to
251b621
Compare
tanx
approved these changes
Mar 16, 2019
Contributor
tanx
left a comment
tanx
left a comment
There was a problem hiding this comment.
@valentinewallace made two small changes and tested this on mainnet. Works like a charm 👌Good to merge from my side if you're ok with the changes.
…osed chan detail.
…and move field down.
valentinewallace
force-pushed
the
show-force-close-time
branch
from
a1b3404 to
71d9d55
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #525.
"Blocks to maturity" doesn't seem like the best copy. Any ideas for what would be better?