This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Display payment preimage in transaction details #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
approved these changes
Jun 18, 2019
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
LGTM 💯
Do you want to add this feature to mobile while we're at it? Otherwise follow-up PR is prob fine.
| <DetailField name="Status"> | ||
| {store.selectedTransaction.statusLabel} | ||
| </DetailField> | ||
| {store.selectedTransaction.preimage ? ( |
Contributor
There was a problem hiding this comment.
Should we add this to the mobile transaction view as well?
Contributor
Author
There was a problem hiding this comment.
@valentinewallace good catch! I added it in 6bd1900
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.