Save settings #422
Save settings #422
Conversation
There was a problem hiding this comment.
i tested the packaged app and it restored all of my settings correctly 👍 very nice!
One thing I noticed was that I get a ton of repetitive "Syncing to chain..."notifications, I'm wondering if we should open a ticket for having a number next to repeated consecutive notifications rather than listing each notification individually
good one on adding the store tests as well :)
| it('should be infinite for unknown rate', () => { | ||
| settings.fiat = 'eur'; | ||
| const rate = helpers.calculateExchangeRate(100000, settings); | ||
| expect(rate, 'to match', /∞/); |
There was a problem hiding this comment.
Would this ever be the case, that the exchange rate is unknown?
There was a problem hiding this comment.
No, but the user's machine might not have an internet connect to fetch a current exchange rate. So we need to handle this case and display something.
| store = new Store(); | ||
| }); | ||
|
|
||
| describe('init()', () => { |
| import AppStorage from '../../../src/action/app-storage'; | ||
| import * as logger from '../../../src/action/log'; | ||
|
|
||
| describe('Action App Storage Unit Tests', () => { |
Good point. I was also hoping the CLI log screen would display the block height. But seems like we only display logs from lnd, not the app's info/error logs. |
Closes #231