This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Dont advertise chans #471
Merged
Dont advertise chans #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Jul 26, 2018
| expect(channel.private, 'to be', true); | ||
| } | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Great that you added a check in the integration tests. The integration tests should stick to using higher level actions that are basically invoked by the UI, so we can kind of replicate the user flow without spinning up a DOM. I'd suggest just adding expect(store1.computedChannels[0].private, 'to be', true); to the previous test.
| const stream = this._grpc.sendStreamCommand('openChannel', { | ||
| node_pubkey: new Buffer(pubkey, 'hex'), | ||
| local_funding_amount: amount, | ||
| private: true, |
valentinewallace
force-pushed
the
dont-advertise-chans
branch
from
4c3086c to
e873b88
Compare
valentinewallace
force-pushed
the
dont-advertise-chans
branch
from
e873b88 to
2464c18
Compare
tanx
approved these changes
Jul 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469