Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@tanx
Copy link
Contributor

@tanx tanx commented Jul 27, 2018

Closes #468

@tanx tanx requested a review from valentinewallace July 27, 2018 05:25
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid bug fix! Tested it, everything works. :) Added 1 suggestion but I'm good to merge.

<MainContent style={styles.content}>
<BalanceDisplay
balanceLabel={balanceLabel}
depositLabel={depositLabel}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: depositLabel --> pendingDepositLabel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there were multiple depositLabels. But short names are good names :)

@tanx tanx merged commit 0f8bdab into master Jul 30, 2018
@tanx tanx deleted the fix-pending-deposit branch July 30, 2018 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants