This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Update exchange rate every 15 minutes #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
approved these changes
Aug 7, 2018
Contributor
tanx
left a comment
tanx
left a comment
There was a problem hiding this comment.
I moved the rate to the config and used setTimeout instead of setInterval. Let me know if that makes sens. Otherwise good to merge from my side.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #497
Tested in packaged app and it updates automatically. Lmk if there's a better way of testing the interval portion or if that's unnecessary.