This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Storybook mobile #560
Merged
Storybook mobile #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error on the svgs that were using xlinkHref and not href, which is required. xlinkHref is deprecated and its usage was removed.
valentinewallace
approved these changes
Aug 29, 2018
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
This looks great! Awesome that so many screens can just work so seamlessly on mobile 👌
Found one bug in a few screens that were missing the href tag, so I pushed a commit fixing that. LGTM now!
Contributor
Author
Yeah our react-native stack is starting to pay off 🎉
Good catch! That fixes the copy-button crashing storybook on mobile 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only addresses a part of #537
This PR allows us to reuse the component stories we developed for react-native-web in a mobile environment.
Integration of the QR code component and screens story would require importing node apis like buffer, stream etc. There is a module that does this for a React Native environment, but I thought I'd save that change for another PR.