Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@valentinewallace
Copy link
Contributor

…command

This prevents loss of user data by ensuring safe shutdown of the daemon.

This functionality doesn't work perfectly and improved functionality is waiting on a few changes to be merged into lnd. Users will need to use ctrl-c to quit the app if the RPC call is not available at the time of app close.

…command

This prevents loss of user data by ensuring safe shutdown of the daemon.
@valentinewallace valentinewallace requested a review from tanx August 28, 2018 01:56
@ghost
Copy link

ghost commented Aug 28, 2018

Tested this out locally and I'm unable to get [INF] LTND: Shutdown complete message in the logs. I'm also seeing the [error] Caught Main Process Error: errors - not sure if they are related.

I tried closing the app multiple times by:

  1. cmd + x
  2. just closing the window by clicking the X button

@cfromknecht
Copy link

Since we're spawning the child process locally, we may want to consider using SIGINT and bypass the RPC altogether. I know @ERKarl reported that the results were inconsistent in testing, were you able to get more reliable results?

@cfromknecht
Copy link

Stopdaemon is kind of nice that it is agnostic to whether lnd is running locally or not, though in the case that we're connecting remote we may not want to call StopDaemon?

@tanx tanx deleted the stopdaemon-on-quit branch September 10, 2018 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants