This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Poll wallet balance #565
Merged
Poll wallet balance #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
The wallet balance polls really well 👍
Neutrino sync still hangs for me til i restart the app.
| * Poll the getInfo api until synced_to_chain is true. | ||
| * @return {Promise<undefined>} | ||
| */ | ||
| async pollInfo() { |
Contributor
There was a problem hiding this comment.
Poll seems to make all these calls way cleaner 👍
| * lnd node all balances, channels and transactions are fetched. | ||
| */ | ||
| observe(store, 'lndReady', async () => { | ||
| // TODO: this is a workaround the deadlock bug in lnd that blocks |
Contributor
There was a problem hiding this comment.
submitted an issue for this todo
src/action/wallet.js
Outdated
| () => typeof this._store.walletAddress === 'string', | ||
| () => this._nav.goNewAddress() | ||
| ); | ||
| observe(this._store, 'walletAddress', () => this._nav.goNewAddress()); |
Contributor
There was a problem hiding this comment.
this doesn't have to be fixed now, but when we change to generating new addresses for every transaction we should switch back from observe to when so we don't always redirect to the NewAddress on new address generation
Contributor
Author
There was a problem hiding this comment.
Good point. I reverted that change.
since wallet balances are now polled
since wallet balances are polled now and transactions are updated anyway when navigating to the transaction list
balances are polled and transaction list is updated when navigating there
This reverts commit 9ba05bd.
tanx
force-pushed
the
poll-wallet-balance
branch
from
a93b92f to
5b04c6e
Compare
ghost
reviewed
Aug 29, 2018
| }); | ||
| }); | ||
|
|
||
| describe('poll()', () => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559, closes #558