This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Node libs #575
Merged
Node libs #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
approved these changes
Aug 29, 2018
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
I'm amazed at how many screens translated automatically to mobile with no code modification :) very excited about this stack payoff!
I added one note about a potential issue with our current method of including node modules in the code. However, if this does turn out to be an issue it can be addressed in a later PR.
Overall changes look good, approving!
tanx
commented
Aug 30, 2018
|
I noticed we added This was a pleasure to review commit-by-commit 👍 . LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537