This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Limit transactions list to last 100 transactions #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Sep 10, 2018
src/computed/transaction.js
Outdated
| const all = [].concat(t, p, i); | ||
| let all = [].concat(t, p, i); | ||
| all.sort((a, b) => b.date.getTime() - a.date.getTime()); | ||
| all = all.slice(0, 100); |
Contributor
There was a problem hiding this comment.
It's fine to do the slice in the return value (line 31). The performance bottleneck isn't V8 but rather the DOM.
| } else { | ||
| store.invoices.push(transaction); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Probably easier to just clone store.transactions 101 times. No need for all the test logic here...
| } | ||
| }); | ||
| ComputedTransaction(store); | ||
| expect(store.computedTransactions.length, 'to equal', 100); |
Contributor
There was a problem hiding this comment.
... since all we need to check is this.
Author
|
@tanx thanks for the feedback - updated. |
Contributor
Ok. Yeah a good first step. We should look into how we can improve performance further with fancier optimizations later. |
tanx
approved these changes
Sep 13, 2018
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544
This PR mitigates the performance issue when there are lots of computed transactions in the transactions list.
The app still feels a little janky/sluggish (~800ms frame), but it's definitely an improvement and quick win over the previous result (~2000ms).