This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Success ntfn invoices #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Oct 1, 2018
src/action/transaction.js
Outdated
| invoice => invoice.id === invoiceId | ||
| ); | ||
| this._notification.display({ | ||
| msg: `Invoice success: received ${inv.amountLabel}`, |
Contributor
There was a problem hiding this comment.
Will this display in fiat or sat?
The purpose of adding this parameter is so we'll then be able to notify the user when they receive an invoice payment.
Tell them how much they've been paid, and give them the option of navigating to the details view for the invoice.
tanx
force-pushed
the
success-ntfn-invoices
branch
from
d8ae9a9 to
c34cd69
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #659.