This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Display 0 instead of - for non-existent fee #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Couldn't it be potentially confusing to omit the fee field, and it would be better to just list it as Can't see why a user would assume 0 fee in the case where the field is missing altogether. |
Author
|
@valentinewallace yep, it could be confusing for users. What about displaying |
Contributor
Contributor
|
Agreed on displaying |
Author
|
Updated. |
ghost
changed the title
Contributor
|
Closing in favor of #711 |
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #673
Not sure if/how we should test this. If do not assign fees to
-undercomputedTransactionsthen the transaction list will look weird with non-empty cells.