-
Notifications
You must be signed in to change notification settings - Fork 168
Enable force close channel #687
Conversation
| if ( | ||
| err && | ||
| err.details && | ||
| err.details.includes('try force closing it instead') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're checking the string contents of the error message here because LND returns a generic/unknown error code.
https://github.com/lightningnetwork/lnd/blob/master/rpcserver.go#L1138
https://github.com/grpc/grpc-go/blob/master/codes/codes.go#L43
|
@ERKarl I'm going to talk to our designer first, because I'm not sure exactly how this feature is going to look currently. We want to warn the user somehow of the tradeoffs. |
|
@valentinewallace sounds good. With the current implementation I used the same "close channel" screen. |
|
@ERKarl So it turns out the desired behavior for these screens is as follows: For this screen: For this screen: These are pretty significant changes to how this PR currently is, so let me know if you're still interested. |
|
@valentinewallace thanks for the update. If I'm not mistaken the channel delete view already works as you described:
To conclude this PR needs to be updated with:
|
|
Closing in favor of #717 |
Closes: #481