This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Clear password field if incorrectly entered #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
approved these changes
Sep 21, 2018
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Clean, simple, works as advertised, solid test, LGTM 🥇
tanx
suggested changes
Oct 1, 2018
test/unit/action/wallet.spec.js
Outdated
| expect(nav.goWait, 'was not called'); | ||
| expect(wallet.setPassword, 'was called with', { | ||
| password: '', | ||
| }); |
Contributor
There was a problem hiding this comment.
I wouldn't stub setPassword in this test since that's the logic you wanna test. Instead, I'd check if store.wallet.password equals ''.
ghost
commented
Oct 3, 2018
tanx
approved these changes
Oct 4, 2018
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #628