Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@valentinewallace
Copy link
Contributor

@valentinewallace valentinewallace commented Nov 9, 2018

Selection screen is done, but I'm still working on the actual seed screens. Still only testing on Android so far.

Closes #579

@tanx tanx force-pushed the seed-select-mobile branch from 7c2dcad to 12b9576 Compare November 12, 2018 15:00
Copy link
Contributor

@tanx tanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this on master, cleaned it up a bit, and refactored some of the components to render correctly using media queries. Let me know what you think. Good to merge from my side.

@tanx tanx mentioned this pull request Nov 12, 2018

const baseStyles = {
content: {
justifyContent: 'center',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue with re-adding this line? Otherwise the content is not vertically centered for me on desktop:
recov_phrase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanx That's my only question. Otherwise, I'm good to merge!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guys keep resizing the window to these totally unrealistic sizes 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Lee's design...

bildschirmfoto 2018-11-13 um 10 56 44

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, I'm good to merge!

ok thanks 🙏

@tanx tanx merged commit 1c6091e into master Nov 13, 2018
@tanx tanx deleted the seed-select-mobile branch November 13, 2018 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants