Skip to content

Initialize lnc-core #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2022
Merged

Initialize lnc-core #1

merged 3 commits into from
Oct 5, 2022

Conversation

@kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Sep 21, 2022 •
edited
Loading

@kaloudis kaloudis mentioned this pull request Sep 21, 2022
Merged
@kaloudis kaloudis marked this pull request as draft September 21, 2022 22:04
@kaloudis kaloudis marked this pull request as ready for review October 4, 2022 19:51
@kaloudis kaloudis requested a review from jamaljsr October 4, 2022 19:52
This was referenced Oct 4, 2022
Merged
Merged
jamaljsr
jamaljsr reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 💪 This is excellent.

Just had one question. Could objects.ts and reservedWords.ts files be moved into lnc-core as well? They are identical in both web & rn repos.

@kaloudis
Copy link
Contributor Author

kaloudis commented Oct 5, 2022

@jamaljsr great catch. Let's add them!

@kaloudis
Copy link
Contributor Author

kaloudis commented Oct 5, 2022

@jamaljsr objects.ts is already used in lnc-core, was pulling it from the within the other packages though. reservedWords.ts is no longer used so it's been deleted from the the two other packages as well.

lightninglabs/lnc-web#64 + lightninglabs/lnc-rn#4 have been updated

jamaljsr
jamaljsr approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool LGTM. Great work! 👌

@kaloudis kaloudis merged commit a474f1f into main Oct 5, 2022
@kaloudis kaloudis deleted the init-project branch October 5, 2022 21:05
@jbrill jbrill mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamaljsr jamaljsr jamaljsr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaloudis @jamaljsr