Subserver timeout fix, add Makefile, run unit tests on CI #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
approved these changes
May 17, 2021
Contributor
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
LGTM, linter fetch just needs a fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while running itests for lightninglabs/faraday#119.
We forgot to add the timeout to two of our subservers.
To avoid this in the future, we're adding a linter config and actually run the linter and unit tests during CI.
Pull Request Checklist
in
lnd_services.goare updated.