Skip to content

Conversation

@starius
Copy link
Collaborator

@starius starius commented Oct 30, 2025

lnd v0.19.3-beta
tapd v0.6.1
go 1.23.12

Remove docs generators as cli-docs depends on Go 1.24.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@starius starius requested review from bhandras and hieblmi October 30, 2025 16:39
@gemini-code-assist
Copy link

Summary of Changes

Hello @starius, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on adjusting the project's dependencies and Go version to facilitate an upcoming litd release. It involves downgrading several core lnd and taproot-assets related modules to specific versions and standardizing the Go version to 1.23.12. Additionally, documentation generation logic that was incompatible with the new Go version has been removed to streamline the build process.

Highlights

  • Dependency Downgrades: Key dependencies including lnd, lndclient, taproot-assets, and taproot-assets/taprpc have been downgraded to specific versions to align with the requirements for the upcoming litd release.
  • Go Version Update: The project's Go version has been standardized and updated to 1.23.12 across the main module and its RPC submodules.
  • Documentation Generator Removal: The documentation generation tools based on cli-docs and their associated Makefile targets have been removed due to incompatibility with the updated Go version requirement.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/main.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades dependencies in go.mod and go.sum to align with the lnd v0.19.3-beta and tapd v0.6.1 releases. It also removes documentation generation tasks from the Makefile and related files, as these depend on Go 1.24, while the project is being downgraded to Go 1.23.12. I have identified a few areas where improvements can be made, primarily focusing on code clarity and dependency management.

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good from a litd perspective with all dependencies!

There's quite a few places that still reference the go version as 1.24.+ though (such as the main.yml file). So would recommend downgrading the golang at those instances as well.

Also, would it be to push this as branch in the upstream loop repo prior to merging, just so that I can properly test it in litd without using replaces (as that interferes with our protos generation)?

@starius
Copy link
Collaborator Author

starius commented Oct 30, 2025

@ViktorT-11 I downgraded all Go versions in the codebase that I found to 1.23.12.
Also pushed branch downgrade-deps to the loop repo so you can use it without replaces:
https://github.com/lightninglabs/loop/tree/downgrade-deps

@starius
Copy link
Collaborator Author

starius commented Oct 31, 2025

Updated Go to 1.24.6 in tools/ dir to fix golangci-lint build. It doesn't affect Loop itself.

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 🙏! Got this working in litd using looprpc v1.0.10 & swapserverrpc v1.0.17 🎉.
LGTM 🔥! Commits could probably be squashed a bit though.

lnd v0.19.3-beta
tapd v0.6.1
go 1.23.12 (except in tools/ where golangci-lint needs Go 1.24)

Remove docs generators as cli-docs depends on Go 1.24.
@starius
Copy link
Collaborator Author

starius commented Oct 31, 2025

Squashed and rebased.

@starius starius merged commit b11c959 into lightninglabs:master Oct 31, 2025
5 checks passed
@starius starius deleted the downgrade-deps branch October 31, 2025 14:12
sputn1ck added a commit to sputn1ck/loop that referenced this pull request Oct 31, 2025
…deps"

This reverts commit b11c959, reversing
changes made to 0a182ee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants