-
Notifications
You must be signed in to change notification settings - Fork 122
go.mod: downgrade deps for litd release #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @starius, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on adjusting the project's dependencies and Go version to facilitate an upcoming litd release. It involves downgrading several core lnd and taproot-assets related modules to specific versions and standardizing the Go version to 1.23.12. Additionally, documentation generation logic that was incompatible with the new Go version has been removed to streamline the build process. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request downgrades dependencies in go.mod and go.sum to align with the lnd v0.19.3-beta and tapd v0.6.1 releases. It also removes documentation generation tasks from the Makefile and related files, as these depend on Go 1.24, while the project is being downgraded to Go 1.23.12. I have identified a few areas where improvements can be made, primarily focusing on code clarity and dependency management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good from a litd perspective with all dependencies!
There's quite a few places that still reference the go version as 1.24.+ though (such as the main.yml file). So would recommend downgrading the golang at those instances as well.
Also, would it be to push this as branch in the upstream loop repo prior to merging, just so that I can properly test it in litd without using replaces (as that interferes with our protos generation)?
|
@ViktorT-11 I downgraded all Go versions in the codebase that I found to 1.23.12. |
|
Updated Go to 1.24.6 in |
e845a44 to
eca6a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you 🙏! Got this working in litd using looprpc v1.0.10 & swapserverrpc v1.0.17 🎉.
LGTM 🔥! Commits could probably be squashed a bit though.
lnd v0.19.3-beta tapd v0.6.1 go 1.23.12 (except in tools/ where golangci-lint needs Go 1.24) Remove docs generators as cli-docs depends on Go 1.24.
eca6a4a to
7d58b65
Compare
|
Squashed and rebased. |
lnd v0.19.3-beta
tapd v0.6.1
go 1.23.12
Remove docs generators as cli-docs depends on Go 1.24.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes