loopd+loopdb: add timeout to DB open #374
Conversation
guggero
requested review from
a team,
Roasbeef,
carlaKC and
yyforyongyu
and removed request for
a team and
Roasbeef
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
Great addition! Just some nittyness around where the user-instructive/ terminal-specific error should live.
loopd/macaroons.go
Outdated
| loopdb.DefaultLoopDBTimeout, macaroons.IPLockChecker, | ||
| ) | ||
| if err == bbolt.ErrTimeout { | ||
| return fmt.Errorf("error while trying to open %s/%s: "+ |
There was a problem hiding this comment.
Great explanatory error!
Just wondering where these errors should live. startMacaroonService and NewBoltSwapStore are both called from our initialize function for the daemon. WDYT about bubbling the bbolt.ErrTimeout all the way up (or wrap it so that we can also have the db name), and then we can have a single descriptive error in the daemon?
If we do it like that, the terminal-specific instructions could also be handled in terminal by checking the response for StartAsSubserver's response.
There was a problem hiding this comment.
Okay, I've implemented your suggestion. What do you think?
To make sure we don't just block for forever if another Loop daemon process is already running, we add a timeout and error out if obtaining the unique file lock fails after 5 seconds.
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
Thanks for updating! LGTM
3 participants
To make sure we don't just block for forever if another Loop daemon
process is already running, we add a timeout and error out if obtaining
the unique file lock fails after 5 seconds.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes