lsat: use package from aperture #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
approved these changes
Apr 28, 2021
| ## Next release | ||
|
|
||
| #### New Features | ||
| - If the payment for an LSAT fails, it is now automatically re-tried. |
Since the lsat code was copied over to aperture a while ago for other projects to use as well, we should migrate over to that shared code also. This will give us the recently added "remove token if payment failed and try again" feature for free along with some other small updates to the lsat package.
We now only use the lsat package imported from aperture and can therefore delete a whole bunch of duplicated code.
Contributor
Author
|
Merged the dependent PR and updated aperture to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to lightninglabs/pool#221.
Depends on lightninglabs/aperture#51.
Updates the Loop code to use aperture's
lsatpackage instead of the duplicated local one.Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes