loopout: use psbt when obtaining the MuSig2 signature #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
musig2-sweep-psbt
branch
2 times, most recently
from
8c171b0 to
180284c
Compare
guggero
approved these changes
Jul 11, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM 🎉
I think just for completeness' sake we should add the UTXO information to the packet, even though it isn't strictly needed.
sweep/sweeper.go
Outdated
| Version: 2, | ||
| TxIn: []*wire.TxIn{{ | ||
| PreviousOutPoint: htlcOutpoint, | ||
| SignatureScript: htlc.SigScript, |
Contributor
There was a problem hiding this comment.
Are np2wkh HTLCs still supported? Otherwise we could scrap the SignatureScript.
| Value: int64(amount), | ||
| PkScript: htlc.PkScript, | ||
| }, | ||
| packet, err := psbt.NewFromUnsignedTx(sweepTx) |
Contributor
There was a problem hiding this comment.
Should we set the WitnessUtxo field on the input as well?
bhandras
force-pushed
the
musig2-sweep-psbt
branch
from
180284c to
53ae5a2
Compare
In this commit we deprecate the sighash field from the MuSig2SignSweepReq request in favour of using a psbt serialized sweep transaction instead. This way the sever gains full transparency about client sweep requests and can assemble the sighash to sign on its own.
bhandras
force-pushed
the
musig2-sweep-psbt
branch
from
53ae5a2 to
f8da106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
swapsserverrpc.MuSig2SignSweepReqwith the sweep txn's psbt to make server side validation of the sighash possible.