utils: fix SelectHopHints for lnd0.15.3 #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
force-pushed
the
lnd0.15.3fix
branch
from
b930616 to
69d9df3
Compare
Member
|
Changes lgtm, just need to fix go.sum first to make CI happy. |
guggero
suggested changes
Oct 20, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Pretty sure this crashes with a nil pointer panic. Can we please hook the PR up on the server side and run a full itest suite to make sure we don't break loop ins?
Member
Author
|
Added a fixup commit 64f8b7b with the |
sputn1ck
force-pushed
the
lnd0.15.3fix
branch
from
64f8b7b to
a4eebf1
Compare
guggero
approved these changes
Oct 20, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Cool, I tested this locally with a zero-conf channel and the SCID alias was encoded correctly in the hop hints 🎉
This commit adds the old SelectHopHints logic to utils in order to allow loop to compile with lnd0.15.3
sputn1ck
force-pushed
the
lnd0.15.3fix
branch
from
a4eebf1 to
83a1848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
SelectHopHintsfrom prelnd v0.15.3-betalogic to utils in order to allow loop to compile withlnd v0.15.3-beta.