loop: Loop In MuSig2 support #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
musig-keyreveal
branch
8 times, most recently
from
6edbef8 to
086f21a
Compare
sputn1ck
reviewed
Feb 6, 2023
Member
sputn1ck
left a comment
sputn1ck
left a comment
There was a problem hiding this comment.
Very nice PR, easy to grok changes 💯
bhandras
force-pushed
the
musig-keyreveal
branch
from
086f21a to
9888bcd
Compare
bhandras
force-pushed
the
musig-keyreveal
branch
from
9888bcd to
5d684e7
Compare
sputn1ck
approved these changes
Feb 16, 2023
Member
sputn1ck
left a comment
sputn1ck
left a comment
There was a problem hiding this comment.
This is not a draft anymore right? LGTM 🐐
loopdb/store.go
Outdated
| // path: loopInBucket/loopOutBucket -> swapBucket[hash] | ||
| // -> senderInternalKeyKey | ||
| // value: serialized private key. | ||
| senderInternalKeyKey = []byte("sender-internal-key") |
Member
There was a problem hiding this comment.
nit: rename to senderInternalPrivKeyKey
server_mock_test.go
Outdated
| } | ||
|
|
||
| var receiverKeyArray [33]byte | ||
| var receiverKeyArray, receriverInternalKeyArray [33]byte |
Member
There was a problem hiding this comment.
nit: typo receriverInternalKeyArray
bhandras
force-pushed
the
musig-keyreveal
branch
from
5d684e7 to
6fe569f
Compare
Member
Author
|
Added shared key encryption to the stored priv keys. |
bhandras
changed the title
|
@sputn1ck: review reminder |
bhandras
force-pushed
the
musig-keyreveal
branch
from
6fe569f to
a491c0d
Compare
GeorgeTsagk
approved these changes
Mar 16, 2023
| // HtlcKeys is a holder of all keys used when constructing the swap HTLC. Since | ||
| // it's used for both loop in and loop out swaps it may hold partial information | ||
| // about the sender or receiver depending on the swap type. | ||
| type HtlcKeys struct { |
Member
There was a problem hiding this comment.
👍 really like this HtlcKeys struct holding all keys
loopdb/store.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| // Store the htlc keys if the contract is recent. |
Member
There was a problem hiding this comment.
This comment is not super clear to me
client.go
Outdated
|
|
||
| import ( | ||
| "context" | ||
| "encoding/hex" |
Member
There was a problem hiding this comment.
this commit message has a typo:
loopdb: encrpyt stored..->loopdb: encrypt stored..This technique allows us to encrpyt..->This technique allows us to encrypt..
|
|
||
| // If this is a MuSig2 swap then we'll generate a brand new key pair | ||
| // and will use that as the internal key for the HTLC. | ||
| if loopdb.CurrentProtocolVersion() >= loopdb.ProtocolVersionMuSig2 { |
Member
There was a problem hiding this comment.
What does the >= imply for the order of protocol versions? Anything that comes after ProtocolVersionMuSig2 is gonna share the same code in the block below? If yes, why?
Member
Author
There was a problem hiding this comment.
This just means that currently we make the assumption that all further protocol upgrades will include musig2 loopin. If this is not the case we'll simply change it.
bhandras
force-pushed
the
musig-keyreveal
branch
from
a491c0d to
4020b2d
Compare
Member
Author
|
ping @sputn1ck |
This commit adds a new protocol version which will add MuSig2 loop in and loop out using key reveal and extends the existing protocol with new message members to be able to pass around htlc internal public keys. The commit also fixes some minor formatting issues in the server proto.
This commit adds a new struct to hold all HTLC keys and refactors the SwapContract which is used by both loopin and loopout swaps to use this new struct. The newly added internal keys will for now hold the script keys to keep everything equivalent but are already stored and read back if the protocol version is set to MuSig2.
This commit changes how we create loopin swaps if the client activates the experimental MuSig2 features. When creating a new loopin swap the client will create (and store) a new key that will be used as the sender's internal key when constructing the HTLC. The client will send the public part to the server and will also receive (and store) the server's (receiver) internal public key.
This commit adds key reveal to MuSig2 loopin swaps' success path. In this case the client reveals their internal HTLC key to the server when the swap invoice is settled. With this key the server can sweep the swap HTLC without any more interaction from the client. We'll do this every block (after the invoice has been settled).
bhandras
force-pushed
the
musig-keyreveal
branch
from
4020b2d to
cd91f90
Compare
sputn1ck
approved these changes
Mar 20, 2023
Member
sputn1ck
left a comment
sputn1ck
left a comment
There was a problem hiding this comment.
I like the change to deriving the shared secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defaults new swaps to MuSig 1.0rc and adds support for MuSig loopin swaps for the success case.
Depends on:
- #546Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes