Autoloop parse old budget to new parameters #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
force-pushed
the
autoloop-parse-old-budget
branch
from
9333490 to
7dba488
Compare
GeorgeTsagk
force-pushed
the
autoloop-parse-old-budget
branch
from
7dba488 to
55c769e
Compare
Member
|
Unit tests seem to be broken, I don't think this is flakiness? |
Member
Author
I don't see any failed tests, it just exits with an error in the end.. I will re-run |
Member
okay so it was flakiness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Description
If an old client updates then we parse the old style budget to our new parameters, where we define an near-infinite interval and assign the last budget refresh to the (now deprecated) budget start timestamp. This way if a client had an autoloop budget in-flight it will remain as is until the moment it is updated.