staticaddr: Minor staging fixes #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
approved these changes
Nov 5, 2024
bhandras
reviewed
Nov 5, 2024
staticaddr/loopin/fsm.go
Outdated
| func (f *FSM) Errorf(format string, args ...interface{}) { | ||
| if f.loopIn == nil { | ||
| log.Errorf(format, args...) | ||
| log.Infof(format, args...) |
Member
There was a problem hiding this comment.
Is there a strong reason to change to Infof?
Collaborator
Author
There was a problem hiding this comment.
in the case of error I guess better to keep it. Will change.
hieblmi
force-pushed
the
static-addr-staging
branch
from
6e62d3b to
60ff75b
Compare
Collaborator
Author
|
Added another commit to increase the confirmation target from 3 to 6. |
hieblmi
force-pushed
the
static-addr-staging
branch
from
60ff75b to
ec3070f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor issues in the staging branch of static addr.